From 44bc065796de7dfde7d1bea8890cb201f6ea04a1 Mon Sep 17 00:00:00 2001 From: gahusb Date: Tue, 19 May 2026 05:03:48 +0900 Subject: [PATCH] fix(music-render): handle AttributeError on dispatch typo (T8 follow-up) Code review found: getattr(sys.modules[__name__], fn_name) raises AttributeError if a dispatch table string entry is a typo. Now caught and reported via webhook_update_task as 'internal dispatch error'. Co-Authored-By: Claude Opus 4.7 (1M context) --- services/music-render/worker.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/services/music-render/worker.py b/services/music-render/worker.py index b84034c..c75b8bc 100644 --- a/services/music-render/worker.py +++ b/services/music-render/worker.py @@ -58,7 +58,12 @@ def _dispatch(payload: dict) -> None: logger.error("unknown job_type=%s task=%s", job_type, task_id) webhook_update_task(task_id, "failed", 0, "", error=f"unknown job_type: {job_type}") return - fn = getattr(_self, fn_name) + try: + fn = getattr(_self, fn_name) + except AttributeError: + logger.error("dispatch table typo for job_type=%s name=%s task=%s", job_type, fn_name, task_id) + webhook_update_task(task_id, "failed", 0, "", error=f"internal dispatch error: {fn_name}") + return fn(task_id, params)